chore: Fix no-unnecessary-condition linting errors #667
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
What type of PR is this?
Chore
What this PR does / why we need it:
@typescript-eslint/no-unnecessary-condition
- 54 errorsWhich issue(s) this PR fixes:
N/A
Special notes for your reviewer:
base.columns[col]
is checked for existence, however the underlying typing does not include conditional existenceuseRef
window.isSecureContext
(proper way to check)check.type
typing)inputRef.current
cloudMode
topK
visited
record could be undefined!= null
check - idiomaticdata
for nowuseRef
undefined
typequerySelectModels
TopKResult
onChange
run.result
can be undefined, use default type and treat it as suchRunForm
could be undefinedmergeColumns
always returns truthy)useRef
v
typing, fix null type checkwhile(true)
columnMap
onChange
Does this PR introduce a user-facing change?:
NONE