-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add hoverSpeed, renderItem props and vertical direction support to LogoLoop #682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… LogoLoop variants Co-authored-by: DavidHDev <[email protected]>
Co-authored-by: DavidHDev <[email protected]>
Co-authored-by: DavidHDev <[email protected]>
| fadeOut | ||
| /> | ||
| {/* Custom rendering with renderItem */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot remove this example from the usage code, it's not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the renderItem example from the usage code as requested. (ec44449)
src/demo/Animations/LogoLoopDemo.jsx
Outdated
| type: 'boolean', | ||
| default: 'true', | ||
| description: 'Whether to pause the animation when hovering over the component.' | ||
| description: 'DEPRECATED: Use hoverSpeed instead. When true, pauses animation on hover (equivalent to hoverSpeed={0}).' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot if it's deprecated, completely remove the prop from the propTable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the deprecated pauseOnHover prop from the props table. (9e8db59)
| }} | ||
| /> | ||
|
|
||
| <PreviewSlider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot replace the current PreviewSwitch which changes the direction with a that will allow users to pick between all 4 options. You'll find it under /components/common
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment appears to be cut off. What should I replace the direction PreviewSwitch with?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot my bad, replace it with a <PreviewSelect /> component, with the 4 direction options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced the direction PreviewSwitch with a PreviewSelect dropdown that supports all 4 direction options (Left, Right, Up, Down). (095f68c)
Co-authored-by: DavidHDev <[email protected]>
Co-authored-by: DavidHDev <[email protected]>
…n options Co-authored-by: DavidHDev <[email protected]>


Enhance LogoLoop component for better flexibility and performance
Summary
This PR enhances the LogoLoop component with new props for better flexibility and control:
✅
hoverSpeedprop - ReplacespauseOnHoverwith a more flexible speed control0for pause (equivalent to oldpauseOnHover={true})pauseOnHover✅
renderItemprop - Custom rendering function for logo items(item, key)as parameters✅ Extended
directionprop - Now supports vertical scrolling'left' | 'right''left' | 'right' | 'up' | 'down'Changes Made
Example Usage
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.