Skip to content

Commit

Permalink
Minor workflow clean up
Browse files Browse the repository at this point in the history
Remove dead link, nonfunctional Coveralls for Codecov, limit permissions, use --verbose to list all test cases, update README
  • Loading branch information
kevinlul committed Dec 3, 2023
1 parent e32d76e commit 6b1196f
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 15 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/node.js.contract.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
pull_request:
paths:
- .github/workflows/node.js.contract.yml
- test/contract/**
- test/contract/*
schedule:
# Daily after 12:00 UTC, depending on Actions availability
- cron: "0 12 * * *"
Expand All @@ -26,7 +26,7 @@ jobs:
node-version: 20
cache: yarn
- run: yarn
- run: yarn test:contract
- run: yarn test:contract --verbose
- uses: codecov/codecov-action@v3
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
19 changes: 7 additions & 12 deletions .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
@@ -1,14 +1,11 @@
# This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions

name: Compile and test

on:
push:
branches: [master]
pull_request:
branches: [master]

permissions:
security-events: write
jobs:
test:
runs-on: ubuntu-latest
Expand All @@ -24,18 +21,16 @@ jobs:
- uses: actions/checkout@v4
with:
submodules: true
- name: Install Node
uses: actions/setup-node@v4
- uses: actions/setup-node@v4
with:
node-version: 20
cache: yarn
- run: yarn
- run: yarn build
- run: yarn test
- name: Coveralls
uses: coverallsapp/github-action@master
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
- run: yarn test --verbose
- uses: codecov/codecov-action@v3
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
- uses: actions/checkout@v4
with:
repository: xyj-3/sarif-js-sdk
Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ Thanks to [YGOPRODECK](https://ygoprodeck.com/) for sponsoring Bastion. Prices p
[![Build Docker image and deploy to Swarm](https://github.com/DawnbrandBots/bastion-bot/actions/workflows/docker.yml/badge.svg)](https://github.com/DawnbrandBots/bastion-bot/actions/workflows/docker.yml)
[![Release to production (Compose)](https://github.com/DawnbrandBots/bastion-bot/actions/workflows/release-compose.yml/badge.svg)](https://github.com/DawnbrandBots/bastion-bot/actions/workflows/release-compose.yml)
[![CodeQL](https://github.com/DawnbrandBots/bastion-bot/actions/workflows/codeql-analysis.yml/badge.svg)](https://github.com/DawnbrandBots/bastion-bot/actions/workflows/codeql-analysis.yml)
[![Contract tests](https://github.com/DawnbrandBots/bastion-bot/actions/workflows/node.js.contract.yml/badge.svg)](https://github.com/DawnbrandBots/bastion-bot/actions/workflows/node.js.contract.yml)

## Discord permissions

Expand Down Expand Up @@ -53,7 +54,7 @@ or roles in question, but this will apply to all bots.
## Contributing

Bastion is written in [TypeScript](https://www.typescriptlang.org/).
It targets [Node.js](https://nodejs.org/) 18+ and
It targets [Node.js](https://nodejs.org/) 20+ and
can be run with or without [Docker](https://docs.docker.com/get-docker/).
It uses [Discord.js](https://discord.js.org/) to talk to Discord.

Expand Down

0 comments on commit 6b1196f

Please sign in to comment.