Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/art, /rush-duel art: reduce calls to Yugipedia #436

Merged
merged 6 commits into from
Apr 14, 2024
Merged

/art, /rush-duel art: reduce calls to Yugipedia #436

merged 6 commits into from
Apr 14, 2024

Conversation

kevinlul
Copy link
Contributor

@kevinlul kevinlul commented Mar 30, 2024

/art no longer calls Yugipedia by assuming the Master Duel redirect exists if there is Master Duel rarity data.
/rush-duel art reduces calls to Yugipedia by skipping the redirect check when illustrations are already specified.
Rework some illustration URL construction logic to create a common yugipediaFileRedirect helper, with unit testing.
Add some unit tests for the ArtSwitcher.

Closes #443

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 59.61538% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 45.84%. Comparing base (d87c07b) to head (65b6bff).

Files Patch % Lines
src/commands/rush-duel.ts 40.74% 16 Missing ⚠️
src/commands/art.ts 37.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #436      +/-   ##
==========================================
+ Coverage   44.29%   45.84%   +1.55%     
==========================================
  Files          33       32       -1     
  Lines        4569     4541      -28     
  Branches      186      203      +17     
==========================================
+ Hits         2024     2082      +58     
+ Misses       2544     2459      -85     
+ Partials        1        0       -1     
Flag Coverage Δ
contract ?
unit 45.84% <59.61%> (+2.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kevinlul kevinlul changed the title Add ArtSwitcher unit tests /art, /rush-duel art: reduce calls to Yugipedia Apr 13, 2024
@kevinlul kevinlul marked this pull request as ready for review April 13, 2024 18:45
@kevinlul kevinlul requested a review from AlphaKretin April 13, 2024 18:45
@kevinlul kevinlul removed the request for review from AlphaKretin April 14, 2024 13:16
@kevinlul kevinlul merged commit 3e42d8f into master Apr 14, 2024
8 checks passed
@kevinlul kevinlul deleted the art.spec branch April 14, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/art, /rush-duel art: reduce calls to Yugipedia
1 participant