Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /metagame command #470

Merged
merged 18 commits into from
Aug 6, 2024
Merged

Add /metagame command #470

merged 18 commits into from
Aug 6, 2024

Conversation

kevinlul
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 76.07053% with 95 lines in your changes missing coverage. Please review.

Project coverage is 50.12%. Comparing base (0c425ce) to head (86fe7f1).

Files Patch % Lines
src/commands/metagame.ts 75.88% 95 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
+ Coverage   47.10%   50.12%   +3.01%     
==========================================
  Files          35       37       +2     
  Lines        4840     5297     +457     
  Branches      247      290      +43     
==========================================
+ Hits         2280     2655     +375     
- Misses       2558     2641      +83     
+ Partials        2        1       -1     
Flag Coverage Δ
contract 39.35% <33.24%> (?)
unit 48.70% <68.26%> (+1.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kevinlul
Copy link
Contributor Author

@kevinlul
Copy link
Contributor Author

Need to either hide the chart when a custom date range is selected or rasterize all options that might be expected.
Furthermore, the rasterizer needs to account for when the page might not show any data, such as during a new format.

image

@kevinlul
Copy link
Contributor Author

Sample API response in this scenario

{"archetypes":[],"format":"OCG","dateCutoffStart":"2024-07-01","dateCutoffEnd":"now","tierMin":2,"tierMax":3,"total":0}

@kevinlul kevinlul marked this pull request as ready for review August 6, 2024 00:50
@kevinlul kevinlul merged commit 369d8a2 into master Aug 6, 2024
7 checks passed
@kevinlul kevinlul deleted the meta branch August 6, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant