Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise card search documentation for Rush Duel [ci skip] #479

Merged
merged 6 commits into from
Jul 29, 2024
Merged

Conversation

kevinlul
Copy link
Contributor

@kevinlul kevinlul commented Jul 1, 2024

Closes #468

@kevinlul
Copy link
Contributor Author

kevinlul commented Jul 1, 2024

@kevinlul kevinlul marked this pull request as ready for review July 28, 2024 17:43
@kevinlul kevinlul requested a review from AlphaKretin July 28, 2024 17:43
Copy link

codecov bot commented Jul 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.10%. Comparing base (b8f4deb) to head (dab5fdd).
Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #479      +/-   ##
==========================================
+ Coverage   46.77%   47.10%   +0.33%     
==========================================
  Files          35       35              
  Lines        4840     4840              
  Branches      245      159      -86     
==========================================
+ Hits         2264     2280      +16     
+ Misses       2575     2560      -15     
+ Partials        1        0       -1     
Flag Coverage Δ
unit 47.10% <ø> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AlphaKretin AlphaKretin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most recent change is my own, so you should also double-check it, but with that complete it looks good

@kevinlul
Copy link
Contributor Author

Awesome, thank you! GitHub pull requests now show a side-by-side comparison of old and new images, so it's interesting to see that side-by-side.

@kevinlul kevinlul merged commit 1ad33c2 into master Jul 29, 2024
6 checks passed
@kevinlul kevinlul deleted the docs branch July 29, 2024 03:38
@kevinlul kevinlul added the documentation Improvements or additions to documentation label Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<> card search extension to Rush Duel follow-up tasks before release
2 participants