Fix replies being ignored #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Four months ago in #434 (1e12130), a change was introduced that synchronized the ignore condition between the message ping and message search listeners. This added a new condition to ignore replies for message search. This behaviour is incorrect, unintuitive, and undocumented as all replies are ignored, not just direct replies, and there are no merits of ignoring even those for message search. This should fix most cases reported in #454, though there still remain uncommon cases of Discord not sending the message event. This also updates the logic in PingMessageListener so it can safely handle replies to other users containing a mention while ignoring reply mentions.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #488 +/- ##
==========================================
- Coverage 47.74% 46.77% -0.98%
==========================================
Files 36 35 -1
Lines 4905 4840 -65
Branches 252 245 -7
==========================================
- Hits 2342 2264 -78
- Misses 2562 2575 +13
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AlphaKretin
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Four months ago in #434 (1e12130), a change was introduced that synchronized the ignore condition between the message ping and message search listeners. This added a new condition to ignore replies for message search. This behaviour is incorrect, unintuitive, and undocumented as all replies are ignored, not just direct replies, and there are no merits of ignoring even those for message search. This should fix most cases reported in #454, though there still remain uncommon cases of Discord not sending the message event. This also updates the logic in PingMessageListener so it can safely handle replies to other users containing a mention while ignoring reply mentions.