Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PersistentTimer's dependency on DiscordInterface #170

Merged
merged 3 commits into from
Feb 16, 2021

Conversation

kevinlul
Copy link
Contributor

@kevinlul kevinlul commented Feb 11, 2021

Description

Part of #161. I think even the intermediate code can be removed from TournamentManager; instead of the link seams, the two key functions can be dependencies, so that the delegate can directly call Eris instead of another level of indirection through DiscordInterface, which might be worthwhile depending on how long TournamentManager sticks around without being ripped up.

Checklist

@coveralls
Copy link

coveralls commented Feb 11, 2021

Pull Request Test Coverage Report for Build 561807932

  • 11 of 16 (68.75%) changed or added relevant lines in 2 files are covered.
  • 11 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 75.869%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/TournamentManager.ts 3 4 75.0%
src/timer.ts 8 12 66.67%
Files with Coverage Reduction New Missed Lines %
src/TournamentManager.ts 11 65.16%
Totals Coverage Status
Change from base Build 550179999: -0.3%
Covered Lines: 892
Relevant Lines: 1113

💛 - Coveralls

@kevinlul kevinlul marked this pull request as ready for review February 12, 2021 18:07
@kevinlul kevinlul requested a review from AlphaKretin February 12, 2021 18:07
Copy link
Contributor

@AlphaKretin AlphaKretin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that I left this in the lurch, it completely passed my notice.

@kevinlul kevinlul merged commit 9cd9a97 into master Feb 16, 2021
@kevinlul kevinlul deleted the timer-discord branch February 16, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants