Support subdirectory deployment and fix API path handling #311
Conversation
|
@Biki-dev is attempting to deploy a commit to the dayuanjiang's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey, noticed #313 is working on the same feature. Would you two like to collaborate? @Biki-dev's utility approach + @zhangxin-github's about page coverage could make a more complete solution. |
DayuanJiang
left a comment
DayuanJiang
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I've added some inline comments—please take a look.
lib/base-path.ts
Outdated
| */ | ||
| export function getBasePath(): string { | ||
| // Only available on client side | ||
| if (typeof window === "undefined") { |
There was a problem hiding this comment.
Because window does not exist on the server, the check typeof window === "undefined" is there to prevent errors during SSR.If you want the function to function the same on both the server and the client, it can be remove also. The environment variable is available during build/SSR time.
app/manifest.ts
Outdated
| theme_color: "#171d26", | ||
| icons: [ | ||
| { | ||
| src: "/favicon-192x192.png", |
There was a problem hiding this comment.
The icon path alse need be updated with the basePath
@DayuanJiang sure |
2 participants
Summary
This PR adds support for deploying the app under a subdirectory by introducing the
NEXT_PUBLIC_BASE_PATHconfiguration and updating client-side asset and API requests to respect the base path.Changes
basePathtonext.config.ts(readsNEXT_PUBLIC_BASE_PATH)lib/base-path.tswithgetApiEndpoint()andgetAssetUrl()getApiEndpoint()getAssetUrl()resolves #301