This repository has been archived by the owner on Jun 15, 2022. It is now read-only.
perf: use decrement instead of splice/indexOf #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In _onAll, individual elements were being removed from an array to track if they had been run. In reality, all that's needed is to know when *all* of them have been run. This can be acheived by simply getting the original array length, and decrementing it upon completion of an element, with a stop condition when the count is zero. In a small benchmark, this increased speeds for resolution of a graph by roughly 4.5x. This was clearly the lowest hanging fruit in terms of performance of asyncgrpah.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
_onAll, individual elements were being removed from an array to trackif they had been run. In reality, all that's needed is to know when
all of them have been run. This can be acheived by simply getting
the original array length, and decrementing it upon completion of an
element, with a stop condition when the count is zero.
In a small benchmark, this increased speeds for resolution of a graph by
roughly 4.5x. This was clearly the lowest hanging fruit in terms of
performance of asyncgrpah.