Skip to content

Comments

Ruff: Add B018 rule#12110

Merged
mtesauro merged 6 commits intoDefectDojo:devfrom
manuel-sommer:ruff_b018
Apr 7, 2025
Merged

Ruff: Add B018 rule#12110
mtesauro merged 6 commits intoDefectDojo:devfrom
manuel-sommer:ruff_b018

Conversation

@manuel-sommer
Copy link
Contributor

@manuel-sommer manuel-sommer commented Mar 26, 2025 •
edited
Loading

No description provided.

@dryrunsecurity
Copy link

dryrunsecurity bot commented Mar 26, 2025 •
edited
Loading

DryRun Security Summary

DefectDojo project files received routine code maintenance and configuration updates with no identified security vulnerabilities.

Expand for full summary

Summary: Multiple files in the DefectDojo project underwent minor code cleanup and configuration updates across various components, with no significant security vulnerabilities detected.

Security Findings:
• No concrete security vulnerabilities were found in the reviewed patches
• The changes primarily consisted of code cleanup, linting configuration updates, and minor functional improvements
• Each patch underwent careful review and did not introduce any direct security risks

Code Analysis

We ran 7 analyzers against 7 files and 1 analyzer had findings. 6 analyzers had no findings.

Analyzer Findings
Configured Codepaths Analyzer 2 findings

Overall Riskiness

🔴 Risk threshold exceeded.

We've notified @mtesauro.

View PR in the DryRun Dashboard.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2025

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Maffooch Maffooch added this to the 2.45.0 milestone Mar 31, 2025
Maffooch
Maffooch requested changes Mar 31, 2025
View reviewed changes
@manuel-sommer manuel-sommer requested a review from Maffooch March 31, 2025 23:26
dogboat
dogboat requested changes Apr 1, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

Conflicts have been resolved. A maintainer will review the pull request shortly.

@manuel-sommer manuel-sommer requested a review from dogboat April 1, 2025 21:12
mtesauro
mtesauro approved these changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro mtesauro merged commit c9d0896 into DefectDojo:dev Apr 7, 2025
76 of 77 checks passed
@manuel-sommer manuel-sommer deleted the ruff_b018 branch April 7, 2025 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtesauro mtesauro mtesauro approved these changes

@dogboat dogboat dogboat approved these changes

@Maffooch Maffooch Maffooch approved these changes

+1 more reviewer

@hblankenship hblankenship hblankenship approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

integration_tests lint parser ui

Projects

None yet

Milestone

2.45.0

Development

Successfully merging this pull request may close these issues.

5 participants

@manuel-sommer @mtesauro @dogboat @hblankenship @Maffooch