Skip to content

Commit

Permalink
fixed additional testcases
Browse files Browse the repository at this point in the history
  • Loading branch information
veenstrajelmer committed Feb 9, 2024
1 parent db00803 commit f5ec735
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
2 changes: 2 additions & 0 deletions hydrolib/core/dflowfm/extold/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -501,6 +501,8 @@ def __init__(self, key: str) -> None:
def raise_error_only_allowed_when(
field: _Field, dependency: _Field, valid_dependency_value: str
):
if isinstance(valid_dependency_value, Enum):
valid_dependency_value = valid_dependency_value.value
error = f"{field.alias} only allowed when {dependency.alias} is {valid_dependency_value}"
raise ValueError(error)

Expand Down
4 changes: 4 additions & 0 deletions hydrolib/core/dflowfm/ini/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,8 @@ def validate_forbidden_fields(

for field in field_names:
if values.get(field) != None:
if isinstance(conditional_value, Enum):
conditional_value = conditional_value.value
raise ValueError(
f"{field} is forbidden when {conditional_field_name} {operator_str(comparison_func)} {conditional_value}"
)
Expand Down Expand Up @@ -228,6 +230,8 @@ def validate_required_fields(

for field in field_names:
if values.get(field) == None:
if isinstance(conditional_value, Enum):
conditional_value = conditional_value.value
raise ValueError(
f"{field} should be provided when {conditional_field_name} {operator_str(comparison_func)} {conditional_value}"
)
Expand Down
2 changes: 1 addition & 1 deletion tests/dflowfm/test_inifield.py
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ def test_initialfield_value_with_missing_value(self):
_ = InitialField(**inifield_values)

expected_message = (
f"value should be provided when datafiletype is {DataFileType.polygon}"
f"value should be provided when datafiletype is {DataFileType.polygon.value}"
)

assert expected_message in str(error.value)

0 comments on commit f5ec735

Please sign in to comment.