add py311 to ci.yml and pyproject.toml #601
Conversation
…eltares/HYDROLIB-core into 598-add-support-for-python-311
| @@ -2,7 +2,7 @@ | |||
| [](https://github.com/psf/black) | |||
| [](https://github.com/Deltares/HYDROLIB-core/actions/workflows/ci.yml) | |||
| [](https://sonarcloud.io/dashboard?id=Deltares_HYDROLIB-core) | |||
|
|
|||
| [](https://pypi.org/project/hydrolib-core) | |||
There was a problem hiding this comment.
I propose to add this badge to the readme.md: https://img.shields.io/pypi/pyversions/hydrolib-core.svg
|
Replaced our |
There was a problem hiding this comment.
I think the change is good, since the StrEnum package can be used in version prior to 3.11.
Git actions also seems to run fine on version 3.8 till 3.11.
Please have a look at my last comment, once that has been resolved the PR is Ok in my opinion.
Do resolve the conflicts before merging :)
pyproject.toml
Outdated
| @@ -20,6 +20,7 @@ numpy = "^1.21" | |||
| pydantic = "^2.5" | |||
| lxml = "^4.6" | |||
| meshkernel = "^4.0.2" | |||
| strenum = "^0.4.15" | |||
There was a problem hiding this comment.
This is the latest version, please consider loosening this constraint to avoid dependency conflicts when combining it with other packages in an environment.
There was a problem hiding this comment.
Updated version requirement for strenum to ^0: >= 0.0.0, <1.0.0
|
No description provided.