- 
                Notifications
    
You must be signed in to change notification settings  - Fork 7
 
Read NetCDF files with demand_priority #2604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel that 99% of the code here could be upstreamed to a table interface implementation on NCDatasets. Without significant tests, I'm hesitant to merge this, especially given the inner/outer repeats that are prone to bugs.
| end | ||
| 
               | 
          ||
| @testitem "netcdf input" begin | ||
| # TODO use NCDatasets.ncgen to create Delft-FEWS flavored NetCDF input files | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
Co-authored-by: Maarten Pronk <[email protected]>
This extends NetCDF reading support (#2434), specifically the
demand_prioritydimension, so these tables:This PR contains some more refactoring of our NetCDF reading code to be able to handle files written by Delft-FEWS. This means e.g. recognizing coordinates by their cf_role or standard_name first, rather than only the variable name. For instance FEWS wouldn't write node_id, but stations with cf_role = timeseries_id.
This still needs more testing, but since I cannot do that now, I made #2617 and propose we add these later.