-
Notifications
You must be signed in to change notification settings - Fork 7
Improved testing for subnetwork communication #2647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a51498b.
visr
reviewed
Oct 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to have more testing.
This also fixes the scaling, right? If you are quite sure about that fix but the new tests are still giving trouble, we can consider merging the fix already before the release (Monday I think).
visr
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues on #2556 and fixes #2632.
The allocation between subnetworks and the primary network had was developed in #2556 and tested on a minimal model with a single secondary network and 1 route for the flow.
In this PR, a more complex test network was created and showed several bugs which were fixed.
In the model below allocation was calculated once as a single network and also as a primary network connected to two secondary networks.
The inflow from the flow boundary of 0.9 m3/s was exactly matched by the 3 user demands of 0.3 m3/s. The results of allocation were compared with the single network version and matched very well (atol = 1e-8).