Skip to content

Conversation

@simulutions
Copy link
Collaborator

@simulutions simulutions commented Oct 14, 2025

Continues on #2556 and fixes #2632.

The allocation between subnetworks and the primary network had was developed in #2556 and tested on a minimal model with a single secondary network and 1 route for the flow.

In this PR, a more complex test network was created and showed several bugs which were fixed.
In the model below allocation was calculated once as a single network and also as a primary network connected to two secondary networks.

The inflow from the flow boundary of 0.9 m3/s was exactly matched by the 3 user demands of 0.3 m3/s. The results of allocation were compared with the single network version and matched very well (atol = 1e-8).

Screenshot 2025-10-24 at 13 44 25

@simulutions simulutions requested a review from visr October 24, 2025 09:26
@simulutions simulutions marked this pull request as ready for review October 24, 2025 09:26
Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have more testing.

This also fixes the scaling, right? If you are quite sure about that fix but the new tests are still giving trouble, we can consider merging the fix already before the release (Monday I think).

@visr visr merged commit 8d12a82 into main Oct 27, 2025
19 checks passed
@visr visr deleted the level_demand_not_respected branch October 27, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

infeasibility analysis test broken in github runner

3 participants