Add RollingDataset to close past forcing data - #1052
Open
evetion wants to merge 1 commit into
Open
Conversation
Member
Author
|
Happy to have someone from the core team take over this PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #1037
Explanation
Wflow uses
deferopen=falsein opening multifile forcing data, so every monthly file remains open. Each accessed forcing variable in each file gets a 64 MB HDF5 chunk cache.For 10.5 years, 126 monthly files * 3 variables * 64 MB that results in roughly 24 GiB.
This adds a
RollingDatasetinstead of the MFD NCDataset, that only holds one forcing file open at a time.Checklist
mainAGENTS.mdare satisfiedAdditional Notes (optional)
Changing
deferopen=truemakes the model slower, as it would reopen the file on each var access. Ideally we upstream this to NCDatasets, I will make an issue.Partially AI generated with GPT-5.6 Sol.