Fix autocomplete for incomplete terms like memento:

DestinyItemManager · Nov 13, 2024 · 3c3ae3a · 3c3ae3a
1 parent 661c2a5
commit 3c3ae3a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/app/search/autocomplete.test.ts b/src/app/search/autocomplete.test.ts
@@ -31,6 +31,8 @@ describe('autocompleteTermSuggestions', () => {
     ['is:bow is:v|oid', 'is:bow is:void'],
     ['season:>outl', 'season:>outlaw'],
     ['not(', 'Expected failure'],
+    ['memento:', 'memento:any'],
+    ['foo memento:', 'foo memento:any'],
   ];
 
   const plainStringCases: [query: string, mockCandidate: string][] = [['jotu', 'jötunn']];

diff --git a/src/app/search/autocomplete.ts b/src/app/search/autocomplete.ts
@@ -4,7 +4,7 @@ import { compact, uniqBy } from 'app/utils/collections';
 import { chainComparator, compareBy, reverseComparator } from 'app/utils/comparators';
 import { ArmoryEntry, getArmorySuggestions } from './armory-search';
 import { canonicalFilterFormats } from './filter-types';
-import { QueryLexerOpenQuotesError, lexer, makeCommentString, parseQuery } from './query-parser';
+import { lexer, makeCommentString, parseQuery, QueryLexerError } from './query-parser';
 import { FiltersMap, SearchConfig, Suggestion } from './search-config';
 import { plainString } from './text-utils';
 
@@ -281,7 +281,7 @@ function findLastFilter(queryUpToCaret: string): number[] | null {
     }
   } catch (e) {
     // If the lexer failed because of unmatched quotes, that's *definitely* something to autocomplete!
-    if (e instanceof QueryLexerOpenQuotesError) {
+    if (e instanceof QueryLexerError) {
       incompleteFilterIndices = [e.startIndex];
     }
   }