Merge pull request #10851 from DestinyItemManager/invalid-loadout-ids

Ignore invalid item IDs more broadly
DestinyItemManager · Dec 18, 2024 · 40b8911 · 40b8911
2 parents 921c23b + 8c3c774
commit 40b8911
Showing 1 changed file with 1 addition and 6 deletions.
diff --git a/src/app/loadout/loadout-type-converters.ts b/src/app/loadout/loadout-type-converters.ts
@@ -53,12 +53,7 @@ function convertDimLoadoutItemToLoadoutItem(item: DimLoadoutItem): LoadoutItem {
   const result: LoadoutItem = {
     hash: item.hash,
   };
-  if (
-    item.id &&
-    item.id !== '0' &&
-    // Vendor items have an invalid item ID
-    !item.id.includes('-')
-  ) {
+  if (item.id && item.id !== '0' && /^\d{1,32}$/.test(item.id)) {
     result.id = item.id;
   }
   if (item.amount > 1) {