Fix collectibles #10786
Merged
Fix collectibles #10786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chainrez
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
originally:
- gets state of this collectible for each char
- discards undefineds
- find the smallest (0 result = collected, 1 = not) bitwise state
- returns it
post-lodash-PR:
.finds a collectible state set to not acquired
(find booleanizesstate & DestinyCollectibleState.NotAcquired)- returns that state
Not sure why this results in hiding entries, but whatever, this fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I misread what this was trying to do, and tbh I still don't really understand why it's a
minBy, but putting it back seems to correct the collectibles pages.