Item Popup stat bars display revamp #10821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chainrez
commented
Dec 1, 2024
| @@ -2,7 +2,7 @@ | |||
| * Given a value 0-1, returns a string describing it as a percentage from 0-100 | |||
| */ | |||
| export function percent(val: number): string { | |||
| return `${Math.min(100, Math.floor(100 * val))}%`; | |||
| return `${Math.min(100, Math.floor((1000 * val) / 10))}%`; | |||
There was a problem hiding this comment.
This fixed a JS rounding issue. .29 would become 28%.
bhollis
approved these changes
Dec 2, 2024
bhollis
reviewed
Dec 9, 2024
| opacity: 0.8; | ||
| } | ||
|
|
||
| .tooltipNetStat { |
There was a problem hiding this comment.
As a general rule, we don't need to nest selectors unless they have different properties when nested and when un-nested. Otherwise, since they're always uniquely-named, they won't ever conflict with anything else.
There was a problem hiding this comment.
Fair in tooltipNetStat, though some of these simpler class names like "negative" "mod" etc are doing double duty with nesting as bar colors and text colors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, stat bars are made up of multiple segments, each with its own tooltip, some difficult to aim a mouse at.
This PR