Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up StreamDeck module #10865

Merged
merged 8 commits into from
Dec 21, 2024
Merged

Clean up StreamDeck module #10865

merged 8 commits into from
Dec 21, 2024

Conversation

bhollis
Copy link
Contributor

@bhollis bhollis commented Dec 21, 2024

This snuck past me at some point - the StreamDeck integration is contributing unnecessarily to code size. Some problems that are fixed here:

  1. We shouldn't ever import or read store directly - that ends up importing a ton of code. Instead, use selectors and actions.
  2. We don't need two async chunks that are both loaded at the same time.

I haven't tested this because I don't have the StreamDeck emulator installed.

cc @fcannizzaro

@fcannizzaro
Copy link
Contributor

fcannizzaro commented Dec 21, 2024

Hi Ben, since there are multiple broken features I fixed them here #10867, everything now works right.

@bhollis bhollis merged commit c428486 into master Dec 21, 2024
8 checks passed
@bhollis bhollis deleted the stream-deck-chunks branch December 21, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants