Remove the 15-second window where you can't refresh #10906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chainrez
approved these changes
Jan 26, 2025
There was a problem hiding this comment.
In theory, the dead window cannot do anything to relieve Bungie, that Cloudflare doesn't already do. Not without cachebusting that DIM doesn't do.
In practice, all the window could hypothetically do is frustrate the user if other copies of DIM were running and had fresher data (though it sounds like there's a solution to that too soon.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently refuse to refresh the user's profile from Bungie.net unless it's been at least 15 seconds since the last time the profile was updated (according to Bungie's timestamp). This PR removes that limit - they clearly have their own caching to protect against excess traffic, and this just makes it more frustrating to try and load updated data. If users want to bang on the refresh button continuously, we can let them.