Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error output for path resolution #150

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Improve error output for path resolution #150

merged 2 commits into from
Oct 30, 2024

Conversation

lucperkins
Copy link
Member

@lucperkins lucperkins commented Oct 25, 2024 •
edited
Loading

Right now, the error output for path resolution is pretty confusing:

Error: 
   0: http error: error decoding response body: invalid type: string "Flake `foo/bar` not found.", expected struct ResolvedPath at line 1 column 47
   1: error decoding response body: invalid type: string "Flake `foo/bar` not found.", expected struct ResolvedPath at line 1 column 47
   2: invalid type: string "Flake `foo/bar` not found.", expected struct ResolvedPath at line 1 column 47

This PR makes that error output more granular.

@lucperkins lucperkins merged commit 1625629 into main Oct 30, 2024
8 checks passed
@lucperkins lucperkins deleted the resolve-path-error-output branch October 30, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucperkins @cole-h