Initial implementation of fh fetch
#160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucperkins
reviewed
Feb 18, 2025
src/cli/cmd/fetch.rs
Outdated
| token_path: String, | ||
| out: Option<&str>, | ||
| ) -> Result<()> { | ||
| match out { |
There was a problem hiding this comment.
Small nit, but I think we generally prefer the if let Some(out) { ... } else { ... } idiom around these parts
grahamc
reviewed
Feb 18, 2025
cole-h
reviewed
Feb 18, 2025
cole-h
reviewed
Feb 18, 2025
cole-h
reviewed
Feb 18, 2025
Co-authored-by: Cole Helbling <[email protected]>
cole-h
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
LGTM, tested it on this repo and it works fine:
vin@scadrial ~/w/d/fh (fh-fetch-command) 2.2s> cargo r -- fetch DeterminateSystems/fh/0#packages.x86_64-linux.default ./test
Compiling fh v0.1.21 (/home/vin/workspace/detsys/fh)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.37s
Running `target/debug/fh fetch 'DeterminateSystems/fh/0#packages.x86_64-linux.default' ./test`
INFO execute: Resolved DeterminateSystems/fh/0#packages.x86_64-linux.default to /nix/store/4fr2l65x6hkvzpy0xxc9i7v5hq606wh7-fh-20241206-47747e4-0.1.21
INFO execute: Copied /nix/store/4fr2l65x6hkvzpy0xxc9i7v5hq606wh7-fh-20241206-47747e4-0.1.21 to ./test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an initial implementation of
fh fetch. Users can request an out link with--out-link. This is supported natively in nix 2.26, so on lower versions we manually create a symbolic link.