Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add external link checking #305

Merged
merged 10 commits into from
Dec 18, 2023
Merged

Add external link checking #305

merged 10 commits into from
Dec 18, 2023

Conversation

lucperkins
Copy link
Member

No description provided.

@vercel Vercel
Copy link

vercel bot commented Dec 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zero-to-nix ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2023 11:00pm

@netlify Netlify
Copy link

netlify bot commented Dec 18, 2023 •
edited
Loading

✅ Deploy Preview for zero-to-nix ready!

Name Link
🔨 Latest commit 26dff26
🔍 Latest deploy log https://app.netlify.com/sites/zero-to-nix/deploys/6580cf06353427000812712e
😎 Deploy Preview https://deploy-preview-305--zero-to-nix.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lucperkins lucperkins marked this pull request as ready for review December 18, 2023 22:17
@lucperkins lucperkins requested a review from cole-h December 18, 2023 22:17
cole-h
cole-h reviewed Dec 18, 2023
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
cole-h
cole-h approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the fact that its caching is fairly limited, seems fine to me.

@lucperkins lucperkins merged commit 483b95e into main Dec 18, 2023
5 checks passed
@lucperkins lucperkins deleted the link-checker-pt2 branch December 18, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucperkins @cole-h