QUnit: synchronized executeAsyncMock setups and terminates #31442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR synchronizes the setup and teardown of executeAsyncMock across QUnit test files to ensure proper test isolation. The changes move mock lifecycle management from global scope into individual test module hooks (beforeEach/afterEach), preventing potential test interference.
Key Changes:
- Removed global
executeAsyncMock.setup()calls that were executing once per file - Added
executeAsyncMock.setup()tobeforeEachhooks andexecuteAsyncMock.teardown()toafterEachhooks in multiple test modules - Fixed a case in
collectionWidget.tests.jswhere teardown was in the wrong location
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui/collectionWidget.tests.js | Moved executeAsyncMock.teardown() from module-level afterEach to individual test where mock is actually used |
| packages/devextreme/testing/tests/DevExpress.ui.widgets/popup.tests.js | Removed global setup call and added setup/teardown pairs to multiple test modules' beforeEach/afterEach hooks |
| packages/devextreme/testing/tests/DevExpress.ui.widgets/popup.materialTheme.tests.js | Removed global setup call and added setup/teardown pair to module hooks |
| packages/devextreme/testing/tests/DevExpress.ui.widgets/gallery.tests.js | Moved teardown from module afterEach to individual test |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/columnsController.tests.js | Added teardownModule call to afterEach hook |
| packages/devextreme/testing/tests/DevExpress.knockout/collectionWidget.tests.js | Added executeAsyncMock.setup() to beforeEach hook |
| packages/devextreme/testing/tests/Bootstrap Integration/widget_bundled.tests.js | Removed global setup call |
packages/devextreme/testing/tests/DevExpress.ui/collectionWidget.tests.js
Show resolved
Hide resolved
juleari
changed the title
juleari
force-pushed
the
executeAsyncMock
branch
from
8ad086b to
071cd26
Compare
packages/devextreme/testing/tests/DevExpress.ui.widgets/tabPanel.tests.js
Outdated
Show resolved
Hide resolved
juleari
force-pushed
the
executeAsyncMock
branch
from
4789960 to
d0eadb3
Compare
EugeniyKiyashko
approved these changes
Oct 27, 2025
pharret31
approved these changes
Oct 27, 2025
alexslavr
approved these changes
Oct 28, 2025
Alyar666
approved these changes
Oct 30, 2025
marker-dao
approved these changes
Oct 30, 2025
juleari
added a commit
to juleari/DevExtreme
that referenced
this pull request
Oct 30, 2025
juleari
added a commit
that referenced
this pull request
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.