Skip to content

Conversation

@dmirgaev
Copy link
Contributor

No description provided.

@dmirgaev dmirgaev self-assigned this Oct 27, 2025
@dmirgaev dmirgaev requested a review from a team as a code owner October 27, 2025 21:15
Copilot AI review requested due to automatic review settings October 27, 2025 21:15
@dmirgaev dmirgaev added the 25_2 label Oct 27, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where interaction was blocked while hovering over the DataGrid header during dragging operations (T1291988). The fix involves caching the bounding rectangles of dragging panels at the start of a drag operation instead of calculating them repeatedly during drag movement, which was causing performance issues and blocking interactions.

Key changes:

  • Introduced caching mechanism for dragging panel bounding rectangles to improve performance
  • Refactored _pointCreated method signatures to accept an object parameter instead of multiple positional arguments
  • Updated all callers to pass cells collection directly instead of just cell count

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/devextreme/js/__internal/grids/grid_core/columns_resizing_reordering/m_columns_resizing_reordering.ts Added bounding rect caching mechanism and refactored _pointCreated to accept object parameters
packages/devextreme/js/__internal/grids/grid_core/sticky_columns/m_sticky_columns.ts Updated _pointCreated method signatures to pass cells collection instead of length
packages/devextreme/js/__internal/grids/grid_core/sticky_columns/dom.ts Updated to receive cells parameter directly instead of fetching from view
packages/devextreme/js/__internal/grids/grid_core/column_fixing/m_column_fixing.ts Updated to use new object-based _pointCreated signature
packages/devextreme/js/__internal/grids/grid_core/adaptivity/m_adaptivity.ts Updated to use new object-based _pointCreated signature
packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/columnsResizingReorderingModule.tests.js Updated test calls to use new object parameter format

Copilot AI review requested due to automatic review settings October 28, 2025 12:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Copilot AI review requested due to automatic review settings October 28, 2025 13:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings October 28, 2025 20:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Copilot AI review requested due to automatic review settings October 29, 2025 14:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Copilot AI review requested due to automatic review settings October 31, 2025 13:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

@dmirgaev dmirgaev merged commit b5a9487 into DevExpress:25_2 Oct 31, 2025
118 of 119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants