-
Notifications
You must be signed in to change notification settings - Fork 654
DataGrid: fix interaction blocking while hovering over the grid header and dragging (T1291988) #31489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an issue where interaction was blocked while hovering over the DataGrid header during dragging operations (T1291988). The fix involves caching the bounding rectangles of dragging panels at the start of a drag operation instead of calculating them repeatedly during drag movement, which was causing performance issues and blocking interactions.
Key changes:
- Introduced caching mechanism for dragging panel bounding rectangles to improve performance
- Refactored
_pointCreatedmethod signatures to accept an object parameter instead of multiple positional arguments - Updated all callers to pass cells collection directly instead of just cell count
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
packages/devextreme/js/__internal/grids/grid_core/columns_resizing_reordering/m_columns_resizing_reordering.ts |
Added bounding rect caching mechanism and refactored _pointCreated to accept object parameters |
packages/devextreme/js/__internal/grids/grid_core/sticky_columns/m_sticky_columns.ts |
Updated _pointCreated method signatures to pass cells collection instead of length |
packages/devextreme/js/__internal/grids/grid_core/sticky_columns/dom.ts |
Updated to receive cells parameter directly instead of fetching from view |
packages/devextreme/js/__internal/grids/grid_core/column_fixing/m_column_fixing.ts |
Updated to use new object-based _pointCreated signature |
packages/devextreme/js/__internal/grids/grid_core/adaptivity/m_adaptivity.ts |
Updated to use new object-based _pointCreated signature |
packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/columnsResizingReorderingModule.tests.js |
Updated test calls to use new object parameter format |
...e/js/__internal/grids/grid_core/columns_resizing_reordering/m_columns_resizing_reordering.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/grid_core/column_fixing/m_column_fixing.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
...e/js/__internal/grids/grid_core/columns_resizing_reordering/m_columns_resizing_reordering.ts
Show resolved
Hide resolved
...e/js/__internal/grids/grid_core/columns_resizing_reordering/m_columns_resizing_reordering.ts
Outdated
Show resolved
Hide resolved
4f964bc to
8a5e6b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
8a5e6b0 to
03dffc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
...e/js/__internal/grids/grid_core/columns_resizing_reordering/m_columns_resizing_reordering.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/grid_core/column_fixing/m_column_fixing.ts
Outdated
Show resolved
Hide resolved
...e/js/__internal/grids/grid_core/columns_resizing_reordering/m_columns_resizing_reordering.ts
Show resolved
Hide resolved
1e4217a to
a71a22f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
packages/devextreme/js/__internal/grids/grid_core/columns_resizing_reordering/utils.ts
Show resolved
Hide resolved
…e are grouped columns and fixed columns are enabled (T1291988)
…re grouped and fixed columns enabled (T1291988)
a71a22f to
ffe2b7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.
No description provided.