Skip to content

Conversation

@r-farkhutdinov
Copy link
Contributor

No description provided.

@r-farkhutdinov r-farkhutdinov self-assigned this Oct 28, 2025
@r-farkhutdinov r-farkhutdinov marked this pull request as ready for review October 28, 2025 15:31
@r-farkhutdinov r-farkhutdinov requested a review from a team as a code owner October 28, 2025 15:31
Copilot AI review requested due to automatic review settings October 28, 2025 15:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR integrates the FileView component into the Chat MessageBubble to support displaying file attachments. The implementation adds an attachments container to message bubbles and introduces the onAttachmentDownload callback that propagates from Chat through MessageList and MessageGroup down to MessageBubble.

Key changes:

  • Added FileView integration to MessageBubble with new attachments container and rendering logic
  • Implemented onAttachmentDownload event handler propagation through the component hierarchy
  • Updated styling to use CSS Grid layout for file attachments with configurable spacing

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/devextreme/testing/tests/DevExpress.ui.widgets/chatParts/messageBubble.tests.js Added comprehensive tests for FileView rendering, attachments handling, and download callback
packages/devextreme/testing/tests/DevExpress.ui.widgets/chatParts/messageBubble.markup.tests.js Added test verifying attachments container element exists in markup
packages/devextreme/testing/tests/DevExpress.ui.widgets/chatParts/chat.tests.js Added tests for onAttachmentDownload event handling at Chat component level
packages/devextreme/js/__internal/ui/chat/messagelist.ts Added onAttachmentDownload property and propagated it to MessageGroup
packages/devextreme/js/__internal/ui/chat/messagegroup.ts Added onAttachmentDownload property and passed it to MessageBubble options
packages/devextreme/js/__internal/ui/chat/messagebubble.ts Core implementation: added attachments container, FileView integration, and attachment rendering logic
packages/devextreme/js/__internal/ui/chat/file_view/file_view.ts Removed unused CHAT_FILE_VIEW_ITEM_CLASS constant
packages/devextreme/js/__internal/ui/chat/file_view/file.ts Exported CHAT_FILE_NAME_CLASS and CHAT_FILE_SIZE_CLASS constants for testing
packages/devextreme/js/__internal/ui/chat/chat.ts Added onAttachmentDownload action creation, handler, and option change handling
packages/devextreme-scss/scss/widgets/material/chat/_sizes.scss Added $chat-file-view-margin-top variable
packages/devextreme-scss/scss/widgets/material/chat/_index.scss Updated chat-fileview mixin call with new parameters
packages/devextreme-scss/scss/widgets/generic/chat/_sizes.scss Added $chat-file-view-margin-top variable
packages/devextreme-scss/scss/widgets/generic/chat/_index.scss Updated chat-fileview mixin call with new parameters
packages/devextreme-scss/scss/widgets/fluent/chat/_sizes.scss Added $chat-file-view-margin-top variable
packages/devextreme-scss/scss/widgets/fluent/chat/_index.scss Updated chat-fileview mixin call with new parameters
packages/devextreme-scss/scss/widgets/base/chat/layout/chat-fileview/_mixins.scss Added margin-top and grid-template-columns to fileview mixin
packages/devextreme-scss/scss/widgets/base/chat/layout/chat-fileview/_index.scss Changed layout from flex to grid display

Copilot AI review requested due to automatic review settings October 29, 2025 13:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

packages/devextreme/js/__internal/ui/chat/messagegroup.ts:1

  • [nitpick] The order of properties has changed without an apparent reason. Properties should maintain consistent ordering to match the original structure and improve code readability.
import type { Format } from '@js/common/core/localization';

Copilot AI review requested due to automatic review settings October 29, 2025 16:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

Copilot AI review requested due to automatic review settings October 30, 2025 10:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

Copilot AI review requested due to automatic review settings October 30, 2025 12:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.

@r-farkhutdinov r-farkhutdinov merged commit af6ebe7 into DevExpress:25_2 Oct 30, 2025
120 of 130 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants