Appointment Form Redesign: Demos: Update resource icons #31497
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds icon properties to Scheduler resource configurations across all demo frameworks (Angular, React, Vue, jQuery) and updates package dependencies.
Key changes:
- Added
@babel/preset-typescriptdependency and moved@types/file-saver-esto devDependencies in proper alphabetical order - Added
iconattribute to Scheduler<Resource>components across 15 demo examples in all framework variants - Updated pnpm-lock.yaml to reflect Babel and dependency version changes
Reviewed Changes
Copilot reviewed 66 out of 67 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/demos/package.json | Added @babel/preset-typescript and reorganized @types/file-saver-es to devDependencies |
| pnpm-lock.yaml | Updated lockfile with new Babel preset, transitive dependencies, and hash changes |
| apps/demos/Demos/Scheduler/*/index.js | Added icon property to Resource configurations in jQuery demos |
| apps/demos/Demos/Scheduler/*/App.vue | Added icon attribute to DxResource components in Vue demos |
| apps/demos/Demos/Scheduler/*/App.js(x) | Added icon prop to Resource components in React demos |
| apps/demos/Demos/Scheduler/*/app.component.html | Added icon attribute to dxi-resource elements in Angular demos |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
apps/demos/package.json
Outdated
| "@babel/eslint-parser": "catalog:", | ||
| "@babel/preset-env": "7.23.9", | ||
| "@babel/preset-react": "^7.26.3", | ||
| "@babel/preset-typescript": "^7.28.5", |
There was a problem hiding this comment.
why did you add this dependency?
There was a problem hiding this comment.
I was responsible for moving demos to typescript. In this PR I encountered a problem regarding this, demos linting failed because of typescript errors. By installing this depedency the problem is solved
There was a problem hiding this comment.
Do you know what was the exact reason why linting was failing?
I have found the failing job. It looks like it was something wrong with Scheduler/VirtualScrolling/Angular/app/app.component.html file.
So demos linting was failing because of the changes of this PR?
There was a problem hiding this comment.
I made a separate PR without this change, where you can see a failing job: https://github.com/DevExpress/DevExtreme/actions/runs/18911905424/job/53985763307?pr=31513
If we try to remove the babel typescript plugin, the build still fails. By installing this depedency, this issue is resolved and builds fine.
apps/demos/Demos/Scheduler/Adaptability/Angular/app/app.component.html
Outdated
Show resolved
Hide resolved
# Conflicts: # apps/demos/testing/widgets/scheduler/etalons/scheduler_resources_appointment_popup (fluent.blue.light).png
2 participants
No description provided.