Skip to content

Conversation

RRRadicalEdward
Copy link
Collaborator

This PR improves coloring control as requested in https://github.com/Devolutions/IronVNC/pull/988#pullrequestreview-3303353388.

Copy link

Let maintainers know that an action is required on their side

  • Add the label release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)

  • Add the label release-blocker Follow-up is required before cutting a new release if a follow-up is required before cutting a new release

  • Add the label publish-required Please publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc) when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.)

  • Add the label publish-blocker Follow-up is required before publishing libraries if a follow-up is required before publishing libraries

@RRRadicalEdward RRRadicalEdward self-assigned this Oct 10, 2025

#[rstest]
#[case::default(&[], &[], true)]
#[case::default(&[], &[], false)] // is_terminal = false
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In tests, assert_cmd is used to run jetsocat in a child process, where stderr is piped. This means that we always have is_terminal = false. That's why, for example, log_term_coloring with the default case will return false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant