Fixes #123 potential TypeError in checkCertificate when stderr is undefined #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SangHakLee
changed the title
Dexus
reviewed
Oct 26, 2025
Owner
Dexus
left a comment
Dexus
left a comment
There was a problem hiding this comment.
in this case, would it not more correct to fix the stderr if condition and not move the error if condition?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When validating an invalid certificate using
checkCertificate, a runtime error can occur:This happens because the implementation tries to call
.toString()onstderr, which can beundefinedin some cases.#407