Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a simple flashcard script - flashcard.py #374

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Nikhil2346
Copy link

@Nikhil2346 Nikhil2346 commented Nov 6, 2024

PR Title

Flashcard Program

Summary

summary...
A simple flashcard program (without a GUI), that enables the user to enter questions and answers.

Description

The program uses dictionaries and loops (for & while) to randomly ask the user an entered question, and check their accuracy.

The changes are as follows:

  • Created a new script for a simple flashcard program

Checks

in the repository

  • Made no changes that degrades the functioning of the repository
  • Gave each commit a better title (unlike updated README.md)

in the PR

  • Followed the format of the pull_request_template
  • Made the Pull Request in a small level (for the creator's wellfare)
  • Tested the changes you made

Thank You,

Nikhil

A simple flashcard program (without a GUI), that enables the user to enter questions and answers. The program asks the user the entered questions randomly, and checks their accuracy.
Copy link
Collaborator

@hasan-py hasan-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the instructions to submit a script

@Nikhil2346
Copy link
Author

I have changed it now, following the format of this pull request: #266.
Is this acceptable? If not, what document should I be referring to?

Thank you

@Nikhil2346 Nikhil2346 changed the title Create flashcard.py Added a simple flashcard script - flashcard.py Nov 10, 2024
Copy link
Collaborator

@hasan-py hasan-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description looks good to me. But you're missing this part: https://github.com/DhanushNehru/Python-Scripts?tab=readme-ov-file#adding-a-new-script

Specifically, points 3 and 4.

Simple Flashcard Program (without a GUI).
Simple Flashcard Program
Explanation of workings/ logic of flashcard.py
Copy link
Collaborator

@hasan-py hasan-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for organizing it. You're just one step behind. Please update the main README list for your script in alphabetical order. For reference, you can read the README file in our repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants