-
Notifications
You must be signed in to change notification settings - Fork 1
Revision for 0.2 #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Revision for 0.2 #16
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
80c673a
Discontinue support for PHP 5.x
XedinUnknown 8963a33
Added basic Docker setup for PHP 7.0
XedinUnknown 852b450
Removed NetBeans configs
XedinUnknown 6fc1c2b
Added PHPStorm configs
XedinUnknown 45334fc
Updated dependencies
XedinUnknown 28d42b4
Ignoring .env file
XedinUnknown 131f0c2
Removed unused classes
mecha 43b5d99
Updated dependencies
mecha b921f9f
Set branch alias to 0.2.x
mecha 506b7ca
Rewrote module interface using the 0.2 spec
mecha b698c0b
Updated IDE project files
mecha 725d71b
Updated the interface description in the readme
mecha a51ea79
Updated changelog for 0.2.x changes
mecha 2dc8da5
Simplified link in readme
XedinUnknown edd591c
Changed official requirement to PHP 7.0 in Composer
XedinUnknown 8d58f19
Upgraded PHPUnit to version 6
XedinUnknown b0610e1
No longer depending on XPMock
XedinUnknown 9e74c77
No longer depending on Dhii exceptions or stringable
XedinUnknown bcb6285
Fixed tests
XedinUnknown 019b483
Merge branch 'develop' into 0.2.x
XedinUnknown 718f246
Merge branch 'develop' into 0.2.x
XedinUnknown 2b47fb3
Switched to PHP 7.0 compatible coding standard
XedinUnknown 8a73334
Added return type hint to `setup()` method
mecha 10e0d4a
Merge branch '0.2.x' of github.com:Dhii/module-interface into 0.2.x
mecha 47d6543
Build on PHP 7.4 and disallow failure on it
XedinUnknown 6998916
Update deps
XedinUnknown fcd6113
Remove unused deps and scripts
XedinUnknown 5d7be66
Correct typo in version constraint
XedinUnknown d12074f
Requiring PSR container and SP packages
mecha e7fe9b5
Fix obsolete PHPUnit type
XedinUnknown e2b45e7
Merge remote-tracking branch 'origin/0.2.x' into 0.2.x
XedinUnknown 8124a32
Switch to PHP 7.1
XedinUnknown 02d0b92
Add Composer PHPStorm config
XedinUnknown 77e2287
Add workspace config to separate changelist
XedinUnknown 7ddcec2
Update Readme
XedinUnknown 7ac40f6
Further improve readme
XedinUnknown 9b6571c
Type improvements
XedinUnknown 2236f95
Now testing if exception is throwable
XedinUnknown 1abbf93
Merge remote-tracking branch 'origin/0.2.x' into 0.2.x
XedinUnknown File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So let me get this straight.
You're taking an interface, using a mock-hack to make it throwable, then asserting that the mock is throwable?
Sounds legit 🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷♂️