validate hinted attributes on subcontrollers #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
+ Coverage 88.59% 88.62% +0.03%
==========================================
Files 44 44
Lines 2253 2259 +6
==========================================
+ Hits 1996 2002 +6
Misses 257 257 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GDYendell
reviewed
Sep 10, 2025
|
We're currently not checking for non generic alias types e.g. Might also be good to validate hinted subcontrollers, though I guess they're not usually dot-accessed. e: pushed something, setting as draft until I fix some logic with how hinting as an Attribute should work |
jsouter
force-pushed
the
validate-subcontroller-attrs
branch
from
dcd79d6 to
ac94896
Compare
jsouter
force-pushed
the
validate-subcontroller-attrs
branch
from
b50ee48 to
6a666e1
Compare
jsouter
force-pushed
the
validate-subcontroller-attrs
branch
from
6a666e1 to
2ca1bb8
Compare
Co-authored-by: Gary Yendell <[email protected]>
GDYendell
force-pushed
the
validate-subcontroller-attrs
branch
from
46868c2 to
3ccbe0f
Compare
GDYendell
reviewed
Oct 17, 2025
| if attr_class is not type(attr): | ||
| # skip validation if access mode not specified | ||
| if attr_class is Attribute and isinstance(attr, Attribute): | ||
| continue |
There was a problem hiding this comment.
Is this so that the hint can just be Attribute? I am not sure if that is a reasonable thing to do. If you are adding the hint presumably you intend to either read or write it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oversight from #187