Skip to content

Conversation

@rtuck99
Copy link
Contributor

@rtuck99 rtuck99 commented Oct 20, 2025

No description provided.

@rtuck99 rtuck99 marked this pull request as ready for review October 20, 2025 10:34
@rtuck99 rtuck99 requested a review from a team as a code owner October 20, 2025 10:34
@rtuck99 rtuck99 changed the title Add option to connect as mock devices feat: Add option to connect as mock devices Oct 20, 2025
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.75%. Comparing base (6115b04) to head (35f50f3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1245      +/-   ##
==========================================
+ Coverage   94.67%   94.75%   +0.07%     
==========================================
  Files          41       41              
  Lines        2611     2612       +1     
==========================================
+ Hits         2472     2475       +3     
+ Misses        139      137       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DiamondJoseph
Copy link
Contributor

Do you have a use case that requires this? To my mind this should be tracked in the dodal module, as the device_factory allows setting whether to connect sim or not, rather than having multiple potentially overlapping places to define this.

Copy link
Contributor

@tpoliaw tpoliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's currently no way (that I'm aware of?) of marking all device factories as mocks in one change so I can see the motivation for being able to mock an entire beamline in one flag.

This is all about to change though if the device manager change works out so it might be easier to change there? Other than the weirdness it introduces around having mock plans, I'm not against the idea of it being here as well though.

"kind": "planFunctions",
"module": "dodal.plans"
"module": "dodal.plans",
"mock": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a mock field on a plan module is odd. Can we split the Source type into a union where each sub type only has relevant fields?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants