Failing system tests for plans

src/blueapi/startup/example_devices.py

@@ -1,7 +1,23 @@
+from pathlib import Path
+from tempfile import TemporaryDirectory
+
+from dodal.common.beamlines.beamline_utils import set_path_provider
+from dodal.common.visit import LocalDirectoryServiceClient, StaticVisitPathProvider
 from ophyd.sim import Syn2DGauss, SynGauss, SynSignal
 
 from .simmotor import BrokenSynAxis, SynAxisWithMotionEvents
 
+# Some of our plans such as "count" and "spec_scan" require this global
+# singleton to be set
+_tmp_dir = Path(TemporaryDirectory().name)
+set_path_provider(
+    StaticVisitPathProvider(
+        "t01",
+        _tmp_dir,
+        client=LocalDirectoryServiceClient(),
+    )
+)
+
 
 def x(name="x") -> SynAxisWithMotionEvents:
     return SynAxisWithMotionEvents(name=name, delay=1.0, events_per_move=8)

tests/system_tests/test_blueapi_system.py

@@ -1,11 +1,13 @@
 import inspect
+import textwrap
 import time
 from pathlib import Path
 
 import pytest
 from bluesky_stomp.models import BasicAuthentication
 from pydantic import TypeAdapter
 from requests.exceptions import ConnectionError
+from scanspec.specs import Line
 
 from blueapi.client.client import (
     BlueapiClient,
@@ -338,6 +340,44 @@ def test_get_current_state_of_environment(client: BlueapiClient):
     assert client.get_environment() == EnvironmentResponse(initialized=True)
 
 
+@pytest.mark.skip(
+    reason=textwrap.dedent("""
+The client should block until environment reload is complete but it does not,
+this interferes with subsequent tests. See
+https://github.com/DiamondLightSource/blueapi/issues/742
+""")
+)
 def test_delete_current_environment(client: BlueapiClient):
     client.reload_environment()
     assert client.get_environment() == EnvironmentResponse(initialized=True)
+
+
+@pytest.mark.parametrize(
+    "task",
+    [
+        Task(
+            name="count",
+            params={
+                "detectors": [
+                    "image_det",
+                    "current_det",
+                ],
+                "num": 5,
+            },
+        ),
+        Task(
+            name="spec_scan",
+            params={
+                "detectors": [
+                    "image_det",
+                    "current_det",
+                ],
+                "spec": Line("x", 0.0, 10.0, 10) * Line("y", 5.0, 15.0, 20),
+            },
+        ),
+    ],
+)
+def test_plan_runs(client_with_stomp: BlueapiClient, task: Task):
+    final_event = client_with_stomp.run_task(task)
+    assert final_event.is_complete() and not final_event.is_error()
+    assert final_event.state is WorkerState.IDLE