Skip to content

Optimise the method for stripe removal #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Optimise the method for stripe removal #202

wants to merge 6 commits into from

Conversation

@namannimmo10
Copy link
Member

@namannimmo10 namannimmo10 commented Mar 5, 2025 •
edited
Loading

Changes made:

  • avoid creating an index array (matindex)
  • avoid stacking arrays together
  • avoid making extra copies

@namannimmo10 namannimmo10 added the run-zenodo-tests Run Zenodo tests for each PR label Mar 5, 2025
namannimmo10
namannimmo10 commented Mar 6, 2025
View reviewed changes
@neon60
Copy link
Collaborator

neon60 commented Mar 20, 2025 •
edited
Loading

@namannimmo10 Could you please share the benefits of your changes in the issue description?
Memory usage reduction? Performance improvement? Do you have numbers?

@neon60
Copy link
Collaborator

neon60 commented Mar 20, 2025

@namannimmo10 Could you please share the benefits of your changes in the issue description? Memory usage reduction? Performance improvement? Do you have numbers?

Got my answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neon60 neon60 neon60 approved these changes

Assignees

No one assigned

Labels

run-zenodo-tests Run Zenodo tests for each PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@namannimmo10 @neon60 @dkazanc