Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSYS2 bootstrapper #332

Merged
merged 25 commits into from
Sep 27, 2024
Merged

MSYS2 bootstrapper #332

merged 25 commits into from
Sep 27, 2024

Conversation

tieneupin
Copy link
Contributor

@tieneupin tieneupin commented Aug 23, 2024

Resolves issue #327, which enables #294 and #315 to be potentially resolved in the future.

MSYS2 appears to be a lightweight Unix-like terminal in the same vein as Cygwin that allows us to download and install Rust, which newer Python packages use in their backend. This PR creates API endpoints on the server PC from which client PCs without internet access can download MSYS2 and its corresponding packages.

@tieneupin tieneupin added enhancement New feature or request server Relates to the server component client Relates to the client component labels Aug 23, 2024
@tieneupin tieneupin requested a review from d-j-hatton August 23, 2024 18:35
@tieneupin tieneupin self-assigned this Aug 23, 2024
@tieneupin tieneupin changed the title MSYS2 bootstrap MSYS2 bootstrapper Aug 23, 2024
@tieneupin
Copy link
Contributor Author

tieneupin commented Aug 23, 2024

Checks:

  • Download MSYS2 via the server API endpoint
  • Install packages needed to run Murfey and its dependencies via the server API endpoints

src/murfey/server/api/bootstrap.py Fixed Show fixed Hide fixed
src/murfey/server/api/bootstrap.py Fixed Show fixed Hide fixed
src/murfey/server/api/bootstrap.py Dismissed Show resolved Hide resolved
src/murfey/server/api/bootstrap.py Fixed Show fixed Hide fixed
src/murfey/server/api/bootstrap.py Fixed Show fixed Hide fixed
src/murfey/server/api/bootstrap.py Fixed Show resolved Hide resolved
src/murfey/server/api/bootstrap.py Dismissed Show resolved Hide resolved
@tieneupin tieneupin marked this pull request as ready for review September 3, 2024 11:22
src/murfey/server/api/bootstrap.py Dismissed Show dismissed Hide dismissed
src/murfey/server/api/bootstrap.py Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Sep 23, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@tieneupin tieneupin merged commit 9c57c99 into main Sep 27, 2024
17 checks passed
@tieneupin tieneupin deleted the msys2-bootstrap branch September 27, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Relates to the client component enhancement New feature or request server Relates to the server component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants