Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need for an ispyb environment variable #435

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

stephen-riggs
Copy link
Contributor

No description provided.

tieneupin

This comment was marked as outdated.

src/murfey/util/config.py Outdated Show resolved Hide resolved
@tieneupin tieneupin dismissed their stale review January 9, 2025 18:10

Outdated

@tieneupin
Copy link
Contributor

tieneupin commented Jan 9, 2025

I've set the value type for ispyb_credentials and rabbitmq_credentials to be Optional[Path], since we are dealing with full file paths here. murfey_db_credentials is a Path object, since it's integral to Murfey's operation.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 27.06%. Comparing base (f9739aa) to head (4da0bc9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
+ Coverage   27.05%   27.06%   +0.01%     
==========================================
  Files          75       75              
  Lines       10180    10182       +2     
  Branches     1343     1343              
==========================================
+ Hits         2754     2756       +2     
  Misses       7336     7336              
  Partials       90       90              

@tieneupin tieneupin added the server Relates to the server component label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server Relates to the server component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants