Remove serialem code and revise context determination #632
+155
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #632 +/- ##
==========================================
+ Coverage 32.98% 33.31% +0.33%
==========================================
Files 90 90
Lines 11151 11130 -21
Branches 1470 1462 -8
==========================================
+ Hits 3678 3708 +30
+ Misses 7340 7295 -45
+ Partials 133 127 -6 🚀 New features to boost your workflow:
|
…text' function, as it conflicts with some of the metadata determindation logic for SPA and Tomo
…iles; the loading of the 'analyse_created_directories' key should not be needed
…text of CLEM files; removed the corresponding mocks in the test
…ntext, and more files that can
tieneupin
requested changes
Jul 17, 2025
There was a problem hiding this comment.
@stephen-riggs , I've added example files for the CLEM workflow to the analyser test, and have realised that the logic for the CLEM workflow can be optimised, as some of it conflicts with the conditions you've put in place for the SPA and Tomo files. I've also merged the main branch into this one so that ISPyB gets installed correctly.
Could you verify that the contents of murfey.client.analyser are as you intended after resolving merge conflicts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SerialEM code has never been used, and if we want to support SerialEM in future it would be better to redo it. This removes all code relating to it.
Also improves and tests the determination of the context in the analyser.
There are some potential difficulties with distinguishing data and metadata. The biggest problem is mdoc files which appear with the same name in both folders.