Feat/add support for rpop count parameter #1365
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kripu77 can you please fix lint and build issues. |
HI @lucifercr07, please let me know if you see any further issue. |
|
cc @lucifercr07 |
lucifercr07
suggested changes
Jan 8, 2025
There was a problem hiding this comment.
@Kripu77 thanks for contributing, we can make changes to keep error msgs in parity with redis for these commands.
Else all looks good.
|
Hey @lucifercr07 just wanted to check if you've had a look after the changes? |
|
|
|
Closing this PR as the codebase has diverged a lot from the point this PR was raised. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
COUNTparameter withRPOPcommand similar to Redis.