Skip to content

add shutdown command #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SeanChinJunKai
Copy link
Contributor

Closes #1425

@SeanChinJunKai SeanChinJunKai marked this pull request as draft February 12, 2025 06:16
@SeanChinJunKai
Copy link
Contributor Author

@arpitbbhayani, @JyotinderSingh and @lucifercr07 I am not too sure how to implement SHUTDOWN command. I have added the command file. However, I think that once SHUTDOWN command input we should be calling cancel function from server/main.go however that will require passing the cancel function as a parameter.

@arpitbbhayani
Copy link
Contributor

arpitbbhayani commented Feb 14, 2025

@SeanChinJunKai yes. we will need to pass the ctx through and through. that is how we should gracefully shutdown the database.

@SeanChinJunKai
Copy link
Contributor Author

SeanChinJunKai commented Feb 14, 2025

@arpitbbhayani I shall figure something out

@arpitbbhayani
Copy link
Contributor

@SeanChinJunKai any updates? are you still working on this?

@SeanChinJunKai
Copy link
Contributor Author

@arpitbbhayani sorry i’ve been quite busy and haven’t had time to work on it

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IronHawk Port: ABORT command
3 participants