Skip to content

Fixes #1653 GET.WATCH Notified Unexpectedly on GET Operation #1653 #1688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SValanukonda
Copy link

This PR addresses an issue where the watch client notification was incorrectly triggered for get commands or when a command failed with an error.
The fix introduces a conditional check to ensure that:

  1. Notifications are skipped for read-only get commands.
  2. Notifications are only sent if the command executes successfully.

@CLAassistant
Copy link

CLAassistant commented Apr 13, 2025

CLA assistant check
All committers have signed the CLA.

@SValanukonda
Copy link
Author

SValanukonda commented Apr 13, 2025

hi @arpitbbhayani and team , could u check this PR

@SValanukonda SValanukonda changed the title InValidNotifyInWatchMode GET.WATCH Notified Unexpectedly on GET Operation #1653 ### InValidNotifyInWatchMode ### Apr 13, 2025
@SValanukonda SValanukonda changed the title GET.WATCH Notified Unexpectedly on GET Operation #1653 ### InValidNotifyInWatchMode ### Fixes #1653 GET.WATCH Notified Unexpectedly on GET Operation #1653 ### InValidNotifyInWatchMode ### Apr 13, 2025
@SValanukonda SValanukonda changed the title Fixes #1653 GET.WATCH Notified Unexpectedly on GET Operation #1653 ### InValidNotifyInWatchMode ### Fixes #1653 GET.WATCH Notified Unexpectedly on GET Operation #1653 Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants