feat: close behaviour for specific window #3754
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently close behaviour is very limited and cannot be set for specific window. This results in problems with tray icon, where setting WindowCloseBehaviour::LastWindowHides (now DefaultWindowCloseBehaviour::LastWindowHides) will also close the tray icon if windows are not closed in correct order, another option for this issue would be to now set DefaultWindowCloseBehaviour::WindowsHides, but this will result in all windows opening when you click on tray icon which may or may not be intended depending on your app.
With this change it's now possible to:
change a specific window behaviour on runtime
set a specific window to exit an app
set a specific window to hide
...
Breaking changes:
Config.with_close_behaviour is now Config.with_default_window_close_behaviour
WindowCloseBehaviour is now DefaultWindowCloseBehaviour, WindowCloseBehaviour is now for specific window instead
Tested on windows 11
I completly forgot that changeing the branch name closes PR (#3589)