Skip to content

Conversation

@mcmah309
Copy link
Contributor

@mcmah309 mcmah309 commented Feb 20, 2025

Document: #3756

I chose not to leak the implementation information here and rather advise users to not depend on ordering. Otherwise users depending on ordering may have negative downstream effects - changes to the implementation may case downstream code to break without users knowing why (which may happen between non-breaking semver versions), this can easily become out of date, ordering is already not guaranteed with async and changing components.

@mcmah309 mcmah309 requested a review from a team as a code owner February 20, 2025 14:22
@mcmah309 mcmah309 changed the title feat: Add head ordering doc part doc: Add head ordering doc part Mar 13, 2025
Copy link
Member

@jkelleyrtp jkelleyrtp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now, but we should really make the ordering stable. I'm not exactly sure how other frameworks go about this (namely effect ordering) but the fact that components don't run effects in a sensible order will lead to more bugs and quirks. I'd rather not have to document work-arounds and instead make this work predictably.

Documenting is fine as a stop-gap measure but we should try to fix the underlying issue. I've put this into our own bug backlog, but let's make sure the github issue stays around and tracks the bug properly.

@jkelleyrtp jkelleyrtp merged commit 3ee3d06 into DioxusLabs:main Apr 4, 2025
17 checks passed
@mcmah309
Copy link
Contributor Author

mcmah309 commented Apr 5, 2025

Do you want me to close #3756 or is this the issue that was added to the backlog? If so, it should probably be renamed from "Document Level Tags Are Applied In Reverse Order" to "Stabilize Document Level Tag Ordering" and link back to this comment for future reference.

AnteDeliria pushed a commit to AnteDeliria/dioxus that referenced this pull request Jun 2, 2025
AnteDeliria pushed a commit to AnteDeliria/dioxus that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants