Provide HotkeyState on Global Shortcut Events
#3822
+34
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The global shortcuts are otherwise also triggering when the hotkey is being released. This affects at least Windows.
|
I feel like the handlers should still be called and the selection is done in user code. Someone might want to handle released events? |
|
That would require public API changes, but I can definitely implement it that way. |
CryZe
changed the title
HotkeyState on Global Shortcut Events
Instead of ignoring the events where the shortcut is released, the state is now provided as an argument to the event handler.
|
This should be ready to be reviewed again. It includes the breaking changes now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This state is now provided as an argument to the event handler, such that the user can decide whether to react to the global shortcut being released or not.