Fix bug where preloading and using a stylesheet deduplicates the link #3843
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a quick fix for this issue that could be applied immediately.
The issue I came across was that the code below would only show the preload link but not the stylesheet below:
A quick solution would be:
The best solution would be to go to https://github.com/DioxusLabs/dioxus/edit/main/packages/document/src/elements/link.rs and change:
It'll need to support checking to see if the url is a preload, prefetch, etc. I was initially going to use an enum as a second argument in
should_insert_link
and convert the string to the enum for all rel types. And maybe have separate HashSets ofDeduplicationContext
. Something about it just doesn't feel nice. But if someone else wants to jump in and finish this up go for it. The goal is to make it to where preload/prefetch are grouped together and every other rel should be grouped together in their own dedupe. So technically no need for an enum. It could just be a match for those two rels.