Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add logger to logger example #3846

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mcmah309
Copy link

@mcmah309 mcmah309 commented Mar 8, 2025

initializing the logger was missing from the logging example so nothing was ever logged.

@mcmah309 mcmah309 requested a review from a team as a code owner March 8, 2025 17:53
@jkelleyrtp
Copy link
Member

Hmmm - are you sure the logger isn't working? dioxus::launch enables the dioxus-logger crate provided the "logger" feature is enabled (which it is by default).

@mcmah309
Copy link
Author

Ah yes, you are correct. I had these small changes from a few weeks ago when I worked on #3775 and misremembered the reason I made them. I was starting work on somthing else in dioxus so I decided to commit them in this small PR. Still, might be a good idea to include explict logging setup in the logging example. If not, feel free to close.

Side: In addition to #3775 , I thought it would be a good idea to add programmatic filtering to the api e.g. Targets . Which would allow web support for filtering as well. And adding https://crates.io/crates/tracing-log as default might be worthwhile as well (crates like rfd use the log crate so nothing gets logged without it) . But I was waiting on feedback on that PR before doing anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants