Allow spread attributes to be set directly #3881
Open
+119
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, you cannot forward spread attributes through components like this:
That makes it difficult to build component libraries with many general nested components. This PR implements the simpler fix for spreading attributes through components which lets you set the extends prop directly:
I do think we should look into developing a structural typing system for props, but that will probably not fit into this release. https://docs.rs/frunk/latest/frunk/labelled/trait.Transmogrifier.html looks close to what we would need, but it would require more integration
Fixes #3844