signals: Rebuild stale global cache entries automatically#4809
Merged
jkelleyrtp merged 3 commits intoJan 17, 2026
Conversation
tekacs
force-pushed
the
rebuild-global-signal-on-type-mismatch
branch
from
47f3910 to
0a530d0
Compare
tekacs
force-pushed
the
rebuild-global-signal-on-type-mismatch
branch
3 times, most recently
from
6782111 to
d5f29f0
Compare
tekacs
force-pushed
the
rebuild-global-signal-on-type-mismatch
branch
from
d5f29f0 to
2a07a27
Compare
SilentVoid13
pushed a commit
to SilentVoid13/dioxus
that referenced
this pull request
May 21, 2026
…#4809) * signals: Rebuild stale global cache entries automatically * remove log --------- Co-authored-by: Jonathan Kelley <jkelleyrtp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When rebuilding with
dx serve --hot-patch, changing the type of the value held in aGlobalSignalcurrently results in a panic, due to a downcast failure.This patch causes the runtime to evict the existing value with a warning when that happens, rather than panicking.
I considered making the type part of the key, but this feels gentler, since this is a rare occurrence.